Skip to content

Update embassy-sync and embassy-executor#753

Merged
felipebalbi merged 5 commits into
OpenDevicePartnership:mainfrom
bramsdell-ms:embassy-sync-0.8
Apr 10, 2026
Merged

Update embassy-sync and embassy-executor#753
felipebalbi merged 5 commits into
OpenDevicePartnership:mainfrom
bramsdell-ms:embassy-sync-0.8

Conversation

@bramsdell-ms
Copy link
Copy Markdown
Contributor

@bramsdell-ms bramsdell-ms commented Mar 17, 2026

Updating versions for embassy-sync and embassy-executor. Dependent on OpenDevicePartnership/tps6699x#89

bramsdell-ms and others added 2 commits March 13, 2026 20:03
@bramsdell-ms
Update embassy-sync 0.7->0.8, embassy-executor 0.9->0.10, arch->platform
ce9e55c 
Minimal version bumps only - no API or code changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bramsdell-ms
Point tps6699x at fork with embassy-sync 0.8.0
1ac29d5 
Update tps6699x dependency to use bramsdell-ms fork on
embassy-sync-0.8 branch, which bumps embassy-sync from
0.7.2 to 0.8.0 to match the rest of the workspace.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bramsdell-ms bramsdell-ms requested a review from a team as a code owner March 17, 2026 05:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2026 •
edited
Loading

Cargo Vet Audit Passed

cargo vet has passed in this PR. No new unvetted dependencies were found.

@github-actions github-actions Bot added the cargo vet PRs pending auditor review label Mar 17, 2026
bramsdell-ms
bramsdell-ms commented Mar 17, 2026
View reviewed changes
Comment thread Cargo.toml Outdated
@kurtjd
Copy link
Copy Markdown
Contributor

kurtjd commented Mar 17, 2026 •
edited
Loading

As mentioned on OpenDevicePartnership/tps6699x#89, these versions have not been published to crates.io yet so we can't merge this until that is the case.

@bramsdell-ms
Copy link
Copy Markdown
Contributor Author

bramsdell-ms commented Mar 17, 2026

Which repos are acceptable to refer to by git vs. need to be in crates.io? One option might be to change to a git reference.

@kurtjd
Copy link
Copy Markdown
Contributor

kurtjd commented Mar 17, 2026

Which repos are acceptable to refer to by git vs. need to be in crates.io? One option might be to change to a git reference.

I believe we are trying to stick to crates.io releases only for Embassy. Recently we migrated away from git deps to crates.io for Embassy: #479

@jerrysxie does this match your understanding as well?

@jerrysxie
Copy link
Copy Markdown
Contributor

jerrysxie commented Mar 18, 2026

Which repos are acceptable to refer to by git vs. need to be in crates.io? One option might be to change to a git reference.

I believe we are trying to stick to crates.io releases only for Embassy. Recently we migrated away from git deps to crates.io for Embassy: #479

@jerrysxie does this match your understanding as well?

@kurtjd @bramsdell-ms We switched to crate.io version to be more stable for our clients due to some subtle dependency between the embassy crates. There is no set in stone rule regarding crate.io or git dependency. We just have to be consistent throughout the entire ODP stack to not cause embassy dependency conflict to cause subtle breakages.

For this change, it will be a problem for us since embassy-imxrt is not updated, so if this merged, client downstream depending on embedded-services and embassy-imxrt might have issue as there will be 2 different versions of embassy-sync in the dependency tree.

gjpmsft added 2 commits April 8, 2026 14:13
@gjpmsft
Change tps6699x dependency to new GitHub repo
14878f0 
Updated the tps6699x dependency to point to a new GitHub repository.
@gjpmsft
Merge branch 'main' into embassy-sync-0.8
4b5818a
@gjpmsft gjpmsft force-pushed the embassy-sync-0.8 branch 3 times, most recently from accf788 to bbdf2c0 Compare April 8, 2026 21:47
@gjpmsft
Keep executor 0.9.1, bump embassy-embedded-hal 0.5->0.6, regenerate l…
9ff3f0a 
…ockfiles

Revert embassy-executor from 0.10 back to 0.9.1 in examples to avoid
must_spawn->spawn migration. executor 0.9 is fully compatible with
embassy-sync 0.8.

Bump embassy-embedded-hal 0.5->0.6 in rt633/rt685s-evk examples
(0.5 re-exports embassy-sync 0.7 types, causing version conflicts).

Update tps6699x lockfile pin to latest ODP upstream (embassy-sync 0.8).
Regenerate all Cargo.lock files with minimal targeted updates.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gjpmsft gjpmsft force-pushed the embassy-sync-0.8 branch from bbdf2c0 to 9ff3f0a Compare April 8, 2026 21:48
@gjpmsft gjpmsft requested a review from a team as a code owner April 8, 2026 21:48
@gjpmsft gjpmsft requested a review from felipebalbi April 8, 2026 21:48
jerrysxie
jerrysxie approved these changes Apr 8, 2026
View reviewed changes
Comment thread examples/rt633/Cargo.toml
@felipebalbi felipebalbi merged commit 6011349 into OpenDevicePartnership:main Apr 10, 2026
15 checks passed
williampMSFT added a commit to williampMSFT/embedded-services that referenced this pull request Apr 13, 2026
@williampMSFT
import cargo vet from OpenDevicePartnership#753
5a05caa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjpmsft gjpmsft gjpmsft left review comments

@felipebalbi felipebalbi felipebalbi approved these changes

@jerrysxie jerrysxie jerrysxie approved these changes

@kurtjd kurtjd Awaiting requested review from kurtjd kurtjd is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@tullom tullom Awaiting requested review from tullom tullom is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@RobertZ2011 RobertZ2011 Awaiting requested review from RobertZ2011 RobertZ2011 is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

@williampMSFT williampMSFT Awaiting requested review from williampMSFT williampMSFT is a code owner automatically assigned from OpenDevicePartnership/ec-code-owners

Assignees

No one assigned

Labels

cargo vet PRs pending auditor review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bramsdell-ms @kurtjd @jerrysxie @felipebalbi @gjpmsft